Re: [PATCH v4 3/4] submodule: support running in multiple worktree setup

From: Jens Lehmann <jens.lehmann@web.de>
Date: Jul 22, 2016, 07:32 UTC
Message-ID: <64e9e8fc-50b3-98d8-fca8-6a70028c6398@web.de>
In-Reply-To: <CAGZ79kZB8U+ERNeYpZ-i7Ldip7xbz0ND53g4bzMkzFC3pnyv+w@mail.gmail.com>

Am 21.07.2016 um 01:22 schrieb Stefan Beller:

Show 6 quoted lines

> So maybe we want to drop that series and first talk about a migration plan from
> the current state to a world where we have the existence depending not
> on the url
> parameter, but a boolean variable submodule.<name>.<good_name>.
> Depending on <good_name> a submodule would be ignored or tried to checkout
> in e.g. `submodule update`

Whoa, that's a very intrusive change with a ton of compatibility problems waiting to happen. Maybe its simpler to make "git submodule sync" aware of worktrees and error out with an "you cannot use submodules with different URLs in a worktree scenario" error when the URL is going to change? That should make most use cases work while avoiding the problematic ones.

Show 5 quoted lines

> If we want to move the current behavior of submodules forward, we
> would want to have
> anything but the url as shared variables and then use the url variable
> as a per-worktree
> existence flag.

Without having though deeply about all submodule variables, I see them as worktree specific. E.g. "update=none" is used on our CI- Server to avoid the disk space cost on some checkouts of a certain superproject while using "update=checkout" on others where their content is needed.