Re: [PATCH] Bump core.deltaBaseCacheLimit to 96m

From: Duy Nguyen <pclouds@gmail.com>
Date: May 5, 2014, 11:35 UTC
Message-ID: <CACsJy8CtcbfUHL+yntyU9zLW7Qc7EobbvFTwVzVsiwCJTsVtOg@mail.gmail.com>
In-Reply-To: <vpqwqe0a3ne.fsf@anie.imag.fr>

On Mon, May 5, 2014 at 6:03 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 10 quoted lines

>>> -Default is 16 MiB on all platforms.  This should be reasonable
>>> +Default is 96 MiB on all platforms.  This should be reasonable
>>>  for all users/operating systems, except on the largest projects.
>>>  You probably do not need to adjust this value.
>>
>> So emacs.git falls exactly into the "except on the largest projects"
>> part. Would it make more sense to advise git devs to set this per repo
>> instead?
>
> What's the impact of changing the default for small projects?

Good question. With "git log --patch" or something like that, we could use up to the limit, which is now 96MB. On modern machines that's probably nothing.

Show 7 quoted lines

> My guess is that changing from 16 to 96Mb is just following Moore's law.
> Machines average RAM has increased a lot since the time 16Mb has been
> chosen, and few people would actually notice the difference in RAM usage
> nowadays.
>
> If increasing the default does not harm small projects and benefits to
> big projects, then we should obviously go this way.

I wrote without thinking it through. I agree with you.

> (perhaps adding advices for people using Git on machines with low RAM)

-- 
Duy