Re: [PATCH] Bump core.deltaBaseCacheLimit to 96m
- From
Jeff King <peff@peff.net>
- Date
- May 5, 2014, 20:19 UTC
- Message-ID
- <20140505201928.GA24266@sigill.intra.peff.net>
- In-Reply-To
- <874n14tqty.fsf@fencepost.gnu.org>
On Mon, May 05, 2014 at 01:20:09PM +0200, David Kastrup wrote:
Show 9 quoted lines
> > Would it make more sense to advise git devs to set this per repo > > instead? The majority of (open source) repositories out there are > > small if I'm not mistaken. Of those few big repos, we could have a > > section listing all the tips and tricks to tune git. This is one of > > them. Index v4 and sparse checkout are some other. In future, maybe > > watchman support, split index and untracked cache as well. > > Shrug. The last version of the patch was refused because of wanting > more evidence. I added the evidence.
FWIW, I was the one who asked for the evidence, and this patch looks pretty straightforward and good. We may also want to revisit the data structure for the delta cache, but that can come separately. My earlier tests had not shown improvement with just bumping the cache size, but these ones obviously do. So I think it's worth bumping the default.
-Peff