Re: [PATCH 6/6] fetch-pack: fix deepen shallow over smart http with no-done cap

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 7, 2014, 00:52 UTC
Message-ID: <CACsJy8C_xzPyEF8npz3iQ2hvNFvZNRKwMKy5Tu8QuT3O=TPZpg@mail.gmail.com>
In-Reply-To: <xmqqbnykyrtl.fsf@gitster.dls.corp.google.com>

On Fri, Feb 7, 2014 at 2:16 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> In smart http, upload-pack adds new shallow lines at the beginning of
>> each rpc response. Only shallow lines from the first rpc call are
>> useful. After that they are thrown away. It's designed this way
>> because upload-pack is stateless and has no idea when its shallow
>> lines are helpful or not.
>>
>> So after refs are negotiated with multi_ack_detailed and both sides
>> happy. The server sends "ACK obj-id ready", terminates the rpc call
>
> Is the above "... and both sides are happy, the server sends ..."?

Yes. Although think again, "both sides" is incorrect. If the server side is happy, then it'll send "ACK.. ready" to stop the client. The client can hardly protest.

> Do I understand the situation correctly if I said "The call to
> consume-shallow-list has been here from the very beginning, but it
> should have been adjusted like this patch when no-done was
> introduced."?

It's been there since the introduction of smart http (there are so many "beginnings" in git). The rest is right.

-- 
Duy