Re: [PATCH 2/6] t5538: fix default http port
- From
Jeff King <peff@peff.net>
- Date
- Feb 10, 2014, 19:15 UTC
- Message-ID
- <20140210191521.GA3112@sigill.intra.peff.net>
- In-Reply-To
- <xmqqwqh2su6e.fsf@gitster.dls.corp.google.com>
On Mon, Feb 10, 2014 at 10:23:53AM -0800, Junio C Hamano wrote:
Show 7 quoted lines
> Jeff King <peff@peff.net> writes: > > > Here it is as a Real Patch™. I just based it on master, so it can > > replace your 5537/5538 fix in your series. > > Thanks, looks good. Will put this at the bottom and rebuild the > nd/http-fetch-shallow-fix series on top.
Thanks. It might be worth squashing in the patch below (or sticking it on top), to cover git-daemon as well.
AFAICT, that leaves SVN_HTTPD_PORT, which we do not set by default at all, and the p4 tests, which already do their own similar magic.
The "set GIT_HTTPD_TESTS by default" magic should probably go in a separate series, so I'll roll them by themselves.
-Peff