git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 39/45] parse_pathspec: make sure the prefix part is wildcard-free

From
Duy Nguyen <pclouds@gmail.com>
Date
Mar 20, 2013, 10:54 UTC
Message-ID
<CACsJy8C_vDZPh9C2zFxnS+rz+YJdAPhk6F9wvt+=ge3j=t9txw@mail.gmail.com>
In-Reply-To
<CACsJy8DjrB45kDRiOs9b=VS5Z5=_sdh37Z3Q20sT6iDacLmM+Q@mail.gmail.com>
On Wed, Mar 20, 2013 at 8:32 AM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 5 quoted lines
> On Wed, Mar 20, 2013 at 1:34 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> This seems to break t7300-clean.sh #8
>
> Repeatedly? I saw some t7300-clean.sh failures when running tests in
> parallel, but never been able to reproduce it alone.

Never mind. There is a codepath that does not initialize the new field "prefix" properly. Fixing it now..

-- 
Duy
Previous: Duy NguyenNext: Nguyễn Thái Ngọc Duy
Message 60 of 88 in “nd/parse-pathspec and :(glob) pathspec magic”
  1. 00/45 nd/parse-pathspec and :(glob) pathspec magicNguyễn Thái Ngọc Duy, Mar 15, 2013
  2. 01/45 setup.c: check that the pathspec magic ends with ")"Nguyễn Thái Ngọc Duy, Mar 15, 2013
  3. 02/45 clean: remove unused variable "seen"Nguyễn Thái Ngọc Duy, Mar 15, 2013
  4. 03/45 Move struct pathspec and related functions to pathspec.[ch]Nguyễn Thái Ngọc Duy, Mar 15, 2013
  5. 04/45 pathspec: i18n-ize error strings in pathspec parsing codeNguyễn Thái Ngọc Duy, Mar 15, 2013
  6. 05/45 pathspec: add copy_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  7. 06/45 Add parse_pathspec() that converts cmdline args to struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  8. 07/45 parse_pathspec: save original pathspec for reportingNguyễn Thái Ngọc Duy, Mar 15, 2013
  9. 08/45 parse_pathspec: add PATHSPEC_PREFER_{CWD,FULL}Nguyễn Thái Ngọc Duy, Mar 15, 2013
  10. 09/45 Convert some get_pathspec() calls to parse_pathspec()Nguyễn Thái Ngọc Duy, Mar 15, 2013
  11. 10/45 parse_pathspec: a special flag for max_depth featureNguyễn Thái Ngọc Duy, Mar 15, 2013
  12. Eric SunshineMar 15, 2013
  13. 11/45 parse_pathspec: support stripping submodule trailing slashesNguyễn Thái Ngọc Duy, Mar 15, 2013
  14. Junio C HamanoMar 17, 2013
  15. Duy NguyenMar 18, 2013
  16. 12/45 parse_pathspec: support stripping/checking submodule pathsNguyễn Thái Ngọc Duy, Mar 15, 2013
  17. 13/45 parse_pathspec: support prefixing original patternsNguyễn Thái Ngọc Duy, Mar 15, 2013
  18. 14/45 Guard against new pathspec magic in pathspec matching codeNguyễn Thái Ngọc Duy, Mar 15, 2013
  19. Junio C HamanoMar 17, 2013
  20. 15/45 clean: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  21. 16/45 commit: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  22. 17/45 status: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  23. 18/45 rerere: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  24. 19/45 checkout: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  25. 20/45 rm: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  26. 21/45 ls-files: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  27. 22/45 archive: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  28. Junio C HamanoMar 15, 2013
  29. Duy NguyenMar 16, 2013
  30. Junio C HamanoMar 17, 2013
  31. Duy NguyenMar 17, 2013
  32. Junio C HamanoMar 17, 2013
  33. 23/45 check-ignore: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  34. Adam SpiersApr 12, 2013
  35. Duy NguyenApr 12, 2013
  36. Adam SpiersApr 14, 2013
  37. Duy NguyenApr 14, 2013
  38. Adam SpiersApr 15, 2013
  39. 24/45 add: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  40. 25/45 reset: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  41. 26/45 Convert read_cache_preload() to take struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  42. 27/45 Convert run_add_interactive to use struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  43. John KeepingMar 18, 2013
  44. Duy NguyenMar 19, 2013
  45. John KeepingMar 19, 2013
  46. 28/45 Convert unmerge_cache to take struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  47. 29/45 checkout: convert read_tree_some to take struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  48. 30/45 Convert report_path_error to take struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  49. 31/45 Convert refresh_index to take struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  50. 32/45 Convert {read,fill}_directory to take struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  51. 33/45 Convert add_files_to_cache to take struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  52. 34/45 Convert common_prefix() to use struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  53. 35/45 Remove diff_tree_{setup,release}_pathsNguyễn Thái Ngọc Duy, Mar 15, 2013
  54. 36/45 Remove init_pathspec() in favor of parse_pathspec()Nguyễn Thái Ngọc Duy, Mar 15, 2013
  55. 37/45 Remove match_pathspec() in favor of match_pathspec_depth()Nguyễn Thái Ngọc Duy, Mar 15, 2013
  56. 38/45 tree-diff: remove the use of pathspec's raw[] in follow-rename codepathNguyễn Thái Ngọc Duy, Mar 15, 2013
  57. 39/45 parse_pathspec: make sure the prefix part is wildcard-freeNguyễn Thái Ngọc Duy, Mar 15, 2013
  58. Junio C HamanoMar 19, 2013
  59. Duy NguyenMar 20, 2013
  60. Duy NguyenMar 20, 2013
  61. 40/45 parse_pathspec: preserve prefix length via PATHSPEC_PREFIX_ORIGINNguyễn Thái Ngọc Duy, Mar 15, 2013
  62. Eric SunshineMar 15, 2013
  63. 41/45 Kill limit_pathspec_to_literal() as it's only used by parse_pathspec()Nguyễn Thái Ngọc Duy, Mar 15, 2013
  64. 42/45 pathspec: support :(literal) syntax for noglob pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  65. 43/45 pathspec: make --literal-pathspecs disable pathspec magicNguyễn Thái Ngọc Duy, Mar 15, 2013
  66. 44/45 pathspec: support :(glob) syntaxNguyễn Thái Ngọc Duy, Mar 15, 2013
  67. Eric SunshineMar 15, 2013
  68. 45/45 Rename field "raw" to "_raw" in struct pathspecNguyễn Thái Ngọc Duy, Mar 15, 2013
  69. Junio C HamanoMar 15, 2013
  70. 00/45 parse_pathspec and :(glob) magicNguyễn Thái Ngọc Duy, Mar 20, 2013
  71. 06/45 Add parse_pathspec() that converts cmdline args to struct pathspecNguyễn Thái Ngọc Duy, Mar 20, 2013
  72. Eric SunshineMar 20, 2013
  73. Junio C HamanoMar 22, 2013
  74. 11/45 parse_pathspec: support stripping submodule trailing slashesNguyễn Thái Ngọc Duy, Mar 20, 2013
  75. 12/45 parse_pathspec: support stripping/checking submodule pathsNguyễn Thái Ngọc Duy, Mar 20, 2013
  76. 14/45 Guard against new pathspec magic in pathspec matching codeNguyễn Thái Ngọc Duy, Mar 20, 2013
  77. Eric SunshineMar 20, 2013
  78. 27/45 Convert run_add_interactive to use struct pathspecNguyễn Thái Ngọc Duy, Mar 20, 2013
  79. 39/45 parse_pathspec: make sure the prefix part is wildcard-freeNguyễn Thái Ngọc Duy, Mar 20, 2013
  80. Junio C HamanoMar 20, 2013
  81. Duy NguyenMar 21, 2013
  82. Duy NguyenMar 21, 2013
  83. Junio C HamanoMar 21, 2013
  84. Junio C HamanoMar 21, 2013
  85. Duy NguyenMar 23, 2013
  86. Duy NguyenMar 23, 2013
  87. Junio C HamanoMar 27, 2013
  88. Eric SunshineMar 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.