Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 21, 2013, 05:33 UTC
Message-ID: <20130321053326.GA17446@duynguyen-vnpc.dek-tpc.internal>
In-Reply-To: <7v1ubaeyph.fsf@alter.siamese.dyndns.org>

On Wed, Mar 20, 2013 at 11:02:50AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
> 
> > Junio please pull the series from github [1]....
> > [1] https://github.com/pclouds/git/commits/parse-pathspec
> 
> Please write it like this:
> 
>     https://github.com/pclouds/git parse-pathspec
> 
> so that I can just say
> 
> 	git fetch <<that thing>>
>         git diff nd/magic-pathspecs FETCH_HEAD

OK

> I am still getting this out of 7300, though.

I still can't reproduce it. But I think I found a bug that miscalculates prefix length from absolute paths. Does this "fix" your test?

-- 8< --

diff --git a/setup.c b/setup.c
index 3584f22..6ae147a 100644
--- a/setup.c
+++ b/setup.c
@@ -14,6 +14,7 @@ char *prefix_path_gently(const char *prefix, int *p_len, const char *path)
 		const char *temp = real_path(path);
 		sanitized = xmalloc(len + strlen(temp) + 1);
 		strcpy(sanitized, temp);
+		*p_len = 0;
 	} else {
 		sanitized = xmalloc(len + strlen(path) + 1);
 		if (len)

-- 8< --