Re: [PATCH] rev-parse: Allow @{U} as a synonym for @{u}
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Aug 18, 2011, 01:53 UTC
- Message-ID
- <CACsJy8CX7X3u4i_kXChVHkFK=Q--pRBrxmdvjxrF7wr5_SyakA@mail.gmail.com>
- In-Reply-To
- <7vhb5fd4zy.fsf@alter.siamese.dyndns.org>
On Thu, Aug 18, 2011 at 5:53 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> Letting u/upstream spelled case-insensitively does improve consistency
> among the above, but at the same time if we ever wanted to enhance @{...}
> notation even further in the future, we are restricted to a payload that
> is case insensitive to retain the consistency.
>
> The only remotely semi-plausible enhancement I could think of is perhaps
> to allow @{/regexp} to find a reflog entry that matches the given pattern,
> and in such a use case we would certainly want to take the pattern in a
> case sensitive way. This change closes the door to that, and that is the
> only downside I can think of right now.
>
> I hate to declare that we will never support such a feature with this
> change, but at the same time, I do not think I would need such a feature
> that often. But for that matter, I do not think I would miss @{UpStREAM},
> either, and that takes me back to "Meh" for this change.
>
> What do people think?The itch is probably because people have to release shift, then press shift again to type "@{u}". How about allow case insensitive match if there's only _one_ letter inside @{}?
That would solve the shift problem while leaving door for @{...} extension.-- Duy