Re: [PATCH] rev-parse: Allow @{U} as a synonym for @{u}

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Aug 18, 2011, 09:31 UTC
Message-ID: <4E4CDBF5.4040709@drmicha.warpmail.net>
In-Reply-To: <CACsJy8Dr5q=h-9MhNV0gKtVEn13+DxWwcNn2Prem6-+DyrDmHA@mail.gmail.com>

Nguyen Thai Ngoc Duy venit, vidit, dixit 18.08.2011 10:54:

Show 19 quoted lines

> On Thu, Aug 18, 2011 at 2:15 PM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> For a german keyboard layout, you get @{u} from
>>
>> hold AltGr (Meta)
>> press q
>> press 7
>> release AltGr
>> press u
>> hold AltGr
>> press 0
>>
>> For me, an improvement would be to have the alias
>>
>> @{↓}
> 
> While it's convenient to type, the output now looks strange. If you do
> a screencast, or someone is watching you, they may not understand what
> that syntax is.

just like with any shell or git alias.

Show 9 quoted lines

> 
> Also..
> 
>> As a simpler case, a user could tailor to her keyboard layout with
>>
>> git config revalias.↓ u
> 
> We may also have encoding issue here. What if config file is in utf-8,
> but the console is not?

It's a user setting, tailored for the user's environment.

Show 10 quoted lines

> So I don't we should go this way. There may be a better way to deal
> with different keyboard layouts.
> 
>> Well, this patch is actually specific to a particular keyboard layout!
>> It improves things only for a layout where you get @ and { using a shift
>> key.
> 
> Fully agreed. While it does not help non en-US keyboards, it does not
> cause any harm (jealousy is not classified as harm to me, rather
> motivation ;).

If you sell it as

"rev key is like a config key, so make it case insensitive. As a side effect, it helps certain keyboard layouts and does not harm others."

it may fair a better chance ;)

I guess this should apply to rev^{<type>} as well, then.

Michael