Re: [PATCH v2 01/21] path.c: avoid PATH_MAX as buffer size from get_pathname()

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 15, 2013, 09:02 UTC
Message-ID: <CACsJy8CVQfWdTY_aoH6uMTp0cgTnvF09tC7iLD7CjEL9d9=bzw@mail.gmail.com>
In-Reply-To: <52AD69D4.30605@web.de>

On Sun, Dec 15, 2013 at 3:35 PM, Torsten Bögershausen <tboegi@web.de> wrote:

Show 8 quoted lines

> If we really want to go away from PATH_MAX, is a hard-coded value of 4096 so attractive ?
> Because we can either
>
> a) Re-define PATH_MAX in git-compat-util.h
> b) Use an own  #define in git-compat-util.h, like e.g. GIT_PATH_MAX
> c) Change the code to use a "strbuf" which can grow on demand.
>
> I would prefer c) over b) over a)

Looking at the code again, c) looks feasible after updating git_snpath() to accept a strbuf instead of buffer/size pair.

-- 
Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.