git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v10 20/20] untracked-cache: config option

From
Duy Nguyen <pclouds@gmail.com>
Date
May 15, 2016, 09:43 UTC
Message-ID
<CACsJy8CV4tue8LscUuBcVyu-xnKadtJEajr7+X-q-RhqgdW01g@mail.gmail.com>
In-Reply-To
<1463084415-19826-21-git-send-email-dturner@twopensource.com>
On Fri, May 13, 2016 at 3:20 AM, David Turner <dturner@twopensource.com> wrote:
Show 5 quoted lines
> Add a config option to populate the untracked cache.
>
> For installations that have centrally-managed configuration, it's
> easier to set a config once than to run update-index on every
> repository.

This sounds like the job for core.untrackedCache. It populates after reading the index though (in post_read_index_from) not writing, but I think it accomplishes the same thing.

Show 49 quoted lines
> Signed-off-by: David Turner <dturner@twopensource.com>
> ---
>  Documentation/config.txt | 4 ++++
>  read-cache.c             | 7 ++++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 385ea66..c7b76ef 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -1848,6 +1848,10 @@ imap::
>         The configuration variables in the 'imap' section are described
>         in linkgit:git-imap-send[1].
>
> +index.adduntrackedcache::
> +       Automatically populate the untracked cache whenever the index
> +       is written.
> +
>  index.addwatchmanextension::
>         Automatically add the watchman extension to the index whenever
>         it is written.
> diff --git a/read-cache.c b/read-cache.c
> index 22c64d0..4a1cccf 100644
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -2472,7 +2472,7 @@ static int do_write_index(struct index_state *istate, int newfd,
>         int entries = istate->cache_nr;
>         struct stat st;
>         struct strbuf previous_name_buf = STRBUF_INIT, *previous_name;
> -       int watchman = 0;
> +       int watchman = 0, untracked = 0;
>         uint64_t start = getnanotime();
>
>         for (i = removed = extended = 0; i < entries; i++) {
> @@ -2502,6 +2502,11 @@ static int do_write_index(struct index_state *istate, int newfd,
>             !the_index.last_update)
>                 the_index.last_update = xstrdup("");
>
> +       if (!git_config_get_bool("index.adduntrackedcache", &untracked) &&
> +           untracked &&
> +           !istate->untracked)
> +               add_untracked_cache(&the_index);
> +
>         hdr_version = istate->version;
>
>         hdr.hdr_signature = htonl(CACHE_SIGNATURE);
> --
> 2.4.2.767.g62658d5-twtrsrc
>
-- 
Duy
Previous: David TurnerNext: David Turner
Message 28 of 33 in “index-helper/watchman”
  1. 00/20 index-helper/watchmanDavid Turner, May 12, 2016
  2. 01/20 read-cache.c: fix constness of verify_hdr()David Turner, May 12, 2016
  3. 02/20 read-cache: allow to keep mmap'd memory after readingDavid Turner, May 12, 2016
  4. 03/20 pkt-line: add gentle version of packet_writeDavid Turner, May 12, 2016
  5. Junio C HamanoMay 12, 2016
  6. 04/20 index-helper: new daemon for caching index and related stuffDavid Turner, May 12, 2016
  7. 05/20 index-helper: add --strictDavid Turner, May 12, 2016
  8. 06/20 daemonize(): set a flag before exiting the main processDavid Turner, May 12, 2016
  9. 07/20 index-helper: add --detachDavid Turner, May 12, 2016
  10. 08/20 index-helper: log warningsDavid Turner, May 12, 2016
  11. 09/20 read-cache: add watchman 'WAMA' extensionDavid Turner, May 12, 2016
  12. 10/20 watchman: support watchman to reduce index refresh costDavid Turner, May 12, 2016
  13. 11/20 index-helper: use watchman to avoid refreshing index with lstat()David Turner, May 12, 2016
  14. Ramsay JonesMay 12, 2016
  15. David TurnerMay 13, 2016
  16. index-helper: use watchman to avoid refreshing index with lstat()David Turner, May 13, 2016
  17. Ramsay JonesMay 13, 2016
  18. index-helper: use watchman to avoid refreshing index with lstat()David Turner, May 13, 2016
  19. 12/20 update-index: enable/disable watchman supportDavid Turner, May 12, 2016
  20. 13/20 unpack-trees: preserve index extensionsDavid Turner, May 12, 2016
  21. 14/20 watchman: add a config option to enable the extensionDavid Turner, May 12, 2016
  22. 15/20 index-helper: kill modeDavid Turner, May 12, 2016
  23. 16/20 index-helper: don't run if already runningDavid Turner, May 12, 2016
  24. 17/20 index-helper: autorun modeDavid Turner, May 12, 2016
  25. 18/20 index-helper: optionally automatically runDavid Turner, May 12, 2016
  26. 19/20 trace: measure where the time is spent in the index-heavy operationsDavid Turner, May 12, 2016
  27. 20/20 untracked-cache: config optionDavid Turner, May 12, 2016
  28. Duy NguyenMay 15, 2016
  29. David TurnerMay 16, 2016
  30. Dennis KaarsemakerMay 14, 2016
  31. David TurnerMay 19, 2016
  32. Junio C HamanoMay 19, 2016
  33. David TurnerMay 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.