git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v10 16/20] index-helper: don't run if already running

From
David Turner <dturner@twopensource.com>
Date
May 12, 2016, 20:20 UTC
Message-ID
<1463084415-19826-17-git-send-email-dturner@twopensource.com>
In-Reply-To
<1463084415-19826-1-git-send-email-dturner@twopensource.com>
Signed-off-by: David Turner <dturner@twopensource.com>
---
 index-helper.c          | 7 +++++++
 t/t7900-index-helper.sh | 9 +++++++++
 2 files changed, 16 insertions(+)
diff --git a/index-helper.c b/index-helper.c
index a1b33e4..7b893a0 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -435,6 +435,13 @@ int main(int argc, char **argv)
 		return 0;
 	}
 
+	/* check that no other copy is running */
+	fd = unix_stream_connect(git_path("index-helper.sock"));
+	if (fd > 0)
+		die(_("Already running"));
+	if (errno != ECONNREFUSED && errno != ENOENT)
+		die_errno(_("Unexpected error checking socket"));
+
 	atexit(cleanup);
 	sigchain_push_common(cleanup_on_signal);
 
diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh
index e71b5af..7159971 100755
--- a/t/t7900-index-helper.sh
+++ b/t/t7900-index-helper.sh
@@ -29,4 +29,13 @@ test_expect_success 'index-helper creates usable path file and can be killed' '
 	test_path_is_missing .git/index-helper.sock
 '
 
+test_expect_success 'index-helper will not start if already running' '
+	test_when_finished "git index-helper --kill" &&
+	git index-helper --detach &&
+	test -S .git/index-helper.sock &&
+	test_must_fail git index-helper 2>err &&
+	test -S .git/index-helper.sock &&
+	grep "Already running" err
+'
+
 test_done
-- 
2.4.2.767.g62658d5-twtrsrc
Previous: David TurnerNext: David Turner
Message 23 of 33 in “index-helper/watchman”
  1. 00/20 index-helper/watchmanDavid Turner, May 12, 2016
  2. 01/20 read-cache.c: fix constness of verify_hdr()David Turner, May 12, 2016
  3. 02/20 read-cache: allow to keep mmap'd memory after readingDavid Turner, May 12, 2016
  4. 03/20 pkt-line: add gentle version of packet_writeDavid Turner, May 12, 2016
  5. Junio C HamanoMay 12, 2016
  6. 04/20 index-helper: new daemon for caching index and related stuffDavid Turner, May 12, 2016
  7. 05/20 index-helper: add --strictDavid Turner, May 12, 2016
  8. 06/20 daemonize(): set a flag before exiting the main processDavid Turner, May 12, 2016
  9. 07/20 index-helper: add --detachDavid Turner, May 12, 2016
  10. 08/20 index-helper: log warningsDavid Turner, May 12, 2016
  11. 09/20 read-cache: add watchman 'WAMA' extensionDavid Turner, May 12, 2016
  12. 10/20 watchman: support watchman to reduce index refresh costDavid Turner, May 12, 2016
  13. 11/20 index-helper: use watchman to avoid refreshing index with lstat()David Turner, May 12, 2016
  14. Ramsay JonesMay 12, 2016
  15. David TurnerMay 13, 2016
  16. index-helper: use watchman to avoid refreshing index with lstat()David Turner, May 13, 2016
  17. Ramsay JonesMay 13, 2016
  18. index-helper: use watchman to avoid refreshing index with lstat()David Turner, May 13, 2016
  19. 12/20 update-index: enable/disable watchman supportDavid Turner, May 12, 2016
  20. 13/20 unpack-trees: preserve index extensionsDavid Turner, May 12, 2016
  21. 14/20 watchman: add a config option to enable the extensionDavid Turner, May 12, 2016
  22. 15/20 index-helper: kill modeDavid Turner, May 12, 2016
  23. 16/20 index-helper: don't run if already runningDavid Turner, May 12, 2016
  24. 17/20 index-helper: autorun modeDavid Turner, May 12, 2016
  25. 18/20 index-helper: optionally automatically runDavid Turner, May 12, 2016
  26. 19/20 trace: measure where the time is spent in the index-heavy operationsDavid Turner, May 12, 2016
  27. 20/20 untracked-cache: config optionDavid Turner, May 12, 2016
  28. Duy NguyenMay 15, 2016
  29. David TurnerMay 16, 2016
  30. Dennis KaarsemakerMay 14, 2016
  31. David TurnerMay 19, 2016
  32. Junio C HamanoMay 19, 2016
  33. David TurnerMay 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.