Re: [PATCH] added git-config support for diff.relative setting

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 11, 2014, 13:37 UTC
Message-ID: <CACsJy8CBRzbVrKnKPACuqxLw2N3PiK2O2nE4-C_3jfEp6-2p=g@mail.gmail.com>
In-Reply-To: <548947A0.7000608@shysecurity.com>

On Thu, Dec 11, 2014 at 2:28 PM, Kelson <kelson@shysecurity.com> wrote:

Show 16 quoted lines

> @@ -270,6 +270,14 @@ int git_diff_basic_config(const char *var, const char
> *value, void *cb)
>                 return 0;
>         }
>
> +       if (!strcmp(var, "diff.relative")) {
> +               if (git_config_bool(var, value))
> +                       DIFF_OPT_SET(&default_diff_options, RELATIVE_NAME);
> +               else
> +                       DIFF_OPT_CLR(&default_diff_options, RELATIVE_NAME);
> +               return 0;
> +       }
> +
>         if (starts_with(var, "submodule."))
>                 return parse_submodule_config_option(var, value);
>

This affects more than just git-diff. git_diff_ui_config() may be a better place.

-- 
Duy