Re: [PATCH] added git-config support for diff.relative setting

From: Kelson <kelson@shysecurity.com>
Date: Dec 11, 2014, 21:41 UTC
Message-ID: <548A0F73.80109@shysecurity.com>
In-Reply-To: <CACsJy8CBRzbVrKnKPACuqxLw2N3PiK2O2nE4-C_3jfEp6-2p=g@mail.gmail.com>

That is quite manageable. I was concerned that --relative changes the UI (relative paths) and behavior (excluding files outside the current directory), which might not be clear if placed in just the UI component. You make a great point that git_diff_basic_config drives other commands though, like git-bisect, which --relative would not effect.

-----Original Message-----
From: Duy Nguyen <pclouds@gmail.com>
Sent: 12/11/2014 08:37 AM
To: Kelson <kelson@shysecurity.com>
CC: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] added git-config support for diff.relative setting

On Thu, Dec 11, 2014 at 2:28 PM, Kelson <kelson@shysecurity.com> wrote:

Show 16 quoted lines

> @@ -270,6 +270,14 @@ int git_diff_basic_config(const char *var, const char
> *value, void *cb)
>                  return 0;
>          }
>
> +       if (!strcmp(var, "diff.relative")) {
> +               if (git_config_bool(var, value))
> +                       DIFF_OPT_SET(&default_diff_options, RELATIVE_NAME);
> +               else
> +                       DIFF_OPT_CLR(&default_diff_options, RELATIVE_NAME);
> +               return 0;
> +       }
> +
>          if (starts_with(var, "submodule."))
>                  return parse_submodule_config_option(var, value);
>

This affects more than just git-diff. git_diff_ui_config() may be a better place.