Re: [PATCH] status: hint the user about -uno if read_directory takes too long

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 15, 2013, 12:30 UTC
Message-ID: <CACsJy8BruzR=EGnwA5nc_aCJ5pO4FHyQKxd-9_36U48Ci_FFew@mail.gmail.com>
In-Reply-To: <7vmwu6yqbd.fsf@alter.siamese.dyndns.org>

On Thu, Mar 14, 2013 at 10:05 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

>>> "to speed up by stopping displaying untracked files" does not look
>>> like giving a balanced suggestion.  It is increasing the risk of
>>> forgetting about newly created files the user may want to add, but
>>> the risk is not properly warned.
>>
>> How about "It took X ms to collect untracked files.\nCheck out the
>> option -u for a potential speedup"? I deliberately hide "no" so that
>> the user cannot blindly type and run it without reading document
>> first. We can give full explanation and warning there in the document.
>
> But it makes the advise much less useful to introduce more levels of
> indirections, no?

To me the message's value is the pointer to -uno that not many people know about. And I don't want it to be too verbose as there'll be false positives (cold cache, busy disks, low memory..), 2-3 lines should be max. So indirections are not a concern. You want to speed up, you need to pay some time. Anyway how do you put it to suggest -uno in git-status with all the implications?

-- 
Duy