git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] remote.c: specify correct plural form in "commit diverge" message

From
Duy Nguyen <pclouds@gmail.com>
Date
May 3, 2016, 04:43 UTC
Message-ID
<CACsJy8Bqs5dnKc=VPeuqPZ4OUWVdhYNbewWc5rs-R3FGoZuQ5g@mail.gmail.com>
In-Reply-To
<20160503042008.GB30529@sigill.intra.peff.net>
On Tue, May 3, 2016 at 11:20 AM, Jeff King <peff@peff.net> wrote:
Show 6 quoted lines
> Note that I do not think the singular case can ever trigger with your
> new code. We know that both "ours" and "theirs" are non-zero to get to
> this message, which means "ours + theirs" must be at least 2 (barring
> negative commit counts, of course :) ).
>
> So you could probably replace the Q_() with just a _().

Problem is there are languages with more than one plural form (and the winner is Arabic with six(!) forms [1]). So even if singular form is never used, I think we still should stick to Q_().

[1] https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html
-- 
Duy
Previous: Jeff KingNext: Jeff King
Message 6 of 8 in “bug: incorrect plurality of "commit" in git status”
  1. Alfonsogonzalez, Ernesto (GE Digital)May 2, 2016
  2. remote.c: specify correct plural form in "commit diverge" messageNguyễn Thái Ngọc Duy, May 3, 2016
  3. Stefan BellerMay 3, 2016
  4. Duy NguyenMay 3, 2016
  5. Jeff KingMay 3, 2016
  6. Duy NguyenMay 3, 2016
  7. Jeff KingMay 3, 2016
  8. Duy NguyenMay 3, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.