From: Duy Nguyen Date: Tue, 03 May 2016 04:43:41 GMT Subject: Re: [PATCH] remote.c: specify correct plural form in "commit diverge" message Message-ID: In-Reply-To: <20160503042008.GB30529@sigill.intra.peff.net> On Tue, May 3, 2016 at 11:20 AM, Jeff King wrote: > Note that I do not think the singular case can ever trigger with your > new code. We know that both "ours" and "theirs" are non-zero to get to > this message, which means "ours + theirs" must be at least 2 (barring > negative commit counts, of course :) ). > > So you could probably replace the Q_() with just a _(). Problem is there are languages with more than one plural form (and the winner is Arabic with six(!) forms [1]). So even if singular form is never used, I think we still should stick to Q_(). [1] https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html -- Duy