Re: RFE: support change-id generation natively
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Oct 24, 2013, 05:25 UTC
- Message-ID
- <CACsJy8BoqWMqGPM8JDny6mxkxZzhWrQ6RYZiNK=vzdwXL4a=vQ@mail.gmail.com>
- In-Reply-To
- <8D1AF6D7-F7AA-4E64-B6B3-3C8C931312C3@codeaurora.org>
On Thu, Oct 24, 2013 at 11:11 AM, Nasser Grainawi <nasser@codeaurora.org> wrote:
Show 5 quoted lines
>>> It is not clear to me how you envision to make it work. >> >> I don't have the source code. > > Now you do: https://gerrit.googlesource.com/gerrit/+/master/gerrit-server/src/main/resources/com/google/gerrit/server/tools/root/hooks/commit-msg
Thanks. So you do have tree sha-1 by running "git write-tree". But at that point I'm not sure if cache-tree is written down to disk yet, so write-tree could be more expensive than necessary (one good point for building --change-id in).
-- Duy