Re: RFE: support change-id generation natively

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 24, 2013, 06:01 UTC
Message-ID: <5268B7D6.5050106@viscovery.net>
In-Reply-To: <CACsJy8BoqWMqGPM8JDny6mxkxZzhWrQ6RYZiNK=vzdwXL4a=vQ@mail.gmail.com>

Am 10/24/2013 7:25, schrieb Duy Nguyen:

Show 11 quoted lines

> On Thu, Oct 24, 2013 at 11:11 AM, Nasser Grainawi <nasser@codeaurora.org> wrote:
>>>> It is not clear to me how you envision to make it work.
>>>
>>> I don't have the source code.
>>
>> Now you do: https://gerrit.googlesource.com/gerrit/+/master/gerrit-server/src/main/resources/com/google/gerrit/server/tools/root/hooks/commit-msg
> 
> Thanks. So you do have tree sha-1 by running "git write-tree". But at
> that point I'm not sure if cache-tree is written down to disk yet, so
> write-tree could be more expensive than necessary (one good point for
> building --change-id in).

Consider that I make a commit with a change-id. Then I rewrite the commit, but keep the change-id. Then I push the rewritten commit to Gerrit. Gerrit does not have the objects that the change-id is based on; the change-id is just a random number and has no other significance. Right?

Why do you go all the length in computing a change-id instead of just pulling 20 bytes from /dev/random?

That said, I don't think that --change-id option that the user must not forget to use is any better than a hook that the user must not forget to install.

-- Hannes