Re: [PATCH 2/6] reflog: remove i18n legos in pruning message

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: May 31, 2012, 14:00 UTC
Message-ID: <CACsJy8Bgzkc51N+t=0NyOasJRd2y3U+pyZCGa-qGoDuTQuyOgg@mail.gmail.com>
In-Reply-To: <20120531134538.GA10523@burratino>

On Thu, May 31, 2012 at 8:45 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 8 quoted lines

> Thanks.  Style: how about
>
>        if (!cb->newlog)
>                printf("would prune %s", message);
>        else if (cb->cmd->verbose)
>                printf("prune %s", message);
>
> ?  I think that would be more readable than the lego original.

thanks

Show 5 quoted lines

> BTW I'm not sure if this message would be a good candidate for
> translation.  Especially in the --dry-run case, it feels like output
> that is intended to be simple enough for scripts to parse.  (Though on
> the other hand, I don't know of any scripts or use cases that actually
> parse it, so maybe nobody would mind.)

it's gray area. reflog is not categorized as plumbing. Maybe adding --plumbing for scripts?

-- 
Duy