Re: [PATCH 2/6] reflog: remove i18n legos in pruning message
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 31, 2012, 17:56 UTC
- Message-ID
- <7vlik86xqd.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120531134538.GA10523@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 8 quoted lines
> Thanks. Style: how about
>
> if (!cb->newlog)
> printf("would prune %s", message);
> else if (cb->cmd->verbose)
> printf("prune %s", message);
>
> ? I think that would be more readable than the lego original.That is very much more preferred.
> BTW I'm not sure if this message would be a good candidate for > translation.
These are for human consumption; they used to go to standard error stream back when it was written at 4264dc1 (git reflog expire, 2006-12-19).