Re: [PATCH] git-completion.bash: always swallow error output of for-each-ref

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 13, 2016, 00:53 UTC
Message-ID: <CACsJy8Bg5LzXKuvastiy5WAKBR8D4iOhTcCprYqmNc3fy-HrBA@mail.gmail.com>
In-Reply-To: <20160212234655.GA23398@sigill.intra.peff.net>

On Sat, Feb 13, 2016 at 6:46 AM, Jeff King <peff@peff.net> wrote:

Show 17 quoted lines

> On Sat, Feb 13, 2016 at 12:43:00AM +0100, SZEDER Gábor wrote:
>
>>
>> Quoting SZEDER Gábor <szeder@ira.uka.de>:
>>
>> >Now, if 'git for-each-ref' could understand '**' globbing, not just
>> >fnmatch...
>>
>> Oh, look, though the manpage says:
>>
>>   <pattern>...
>>       If one or more patterns are given, only refs are shown that match
>>       against at least one pattern, either using fnmatch(3) or literally,
>
> Yeah, we might want to update that. Wildmatch is basically fnmatch()
> compatible, but it understands "**" (which I _think_ is the reason we
> picked it up in the first place).

The second reason is consistent behavior across platforms.

Show 5 quoted lines

> I think we dropped it into place by
> default because "**" is otherwise meaningless for fnmatch.
>
> I don't think there are any other differences between the two, but Duy
> probably knows offhand.

Nope. I think that's the only difference, feature-wise, between fnmatch and wildmatch.

> It looks like we mention fnmatch() in a few places in the documentation,
> and AFAIK each of these is now outdated.

-- 
Duy