Re: [PATCH] git-completion.bash: always swallow error output of for-each-ref

From: Jeff King <peff@peff.net>
Date: Feb 12, 2016, 23:46 UTC
Message-ID: <20160212234655.GA23398@sigill.intra.peff.net>
In-Reply-To: <20160213004300.Horde.fMBUV1thpmh_xekWw-EOFAA@webmail.informatik.kit.edu>

On Sat, Feb 13, 2016 at 12:43:00AM +0100, SZEDER Gábor wrote:

Show 11 quoted lines

> 
> Quoting SZEDER Gábor <szeder@ira.uka.de>:
> 
> >Now, if 'git for-each-ref' could understand '**' globbing, not just
> >fnmatch...
> 
> Oh, look, though the manpage says:
> 
>   <pattern>...
>       If one or more patterns are given, only refs are shown that match
>       against at least one pattern, either using fnmatch(3) or literally,

Yeah, we might want to update that. Wildmatch is basically fnmatch() compatible, but it understands "**" (which I _think_ is the reason we picked it up in the first place). I think we dropped it into place by default because "**" is otherwise meaningless for fnmatch.

I don't think there are any other differences between the two, but Duy probably knows offhand.

It looks like we mention fnmatch() in a few places in the documentation, and AFAIK each of these is now outdated.

-Peff