Re: [PATCH] fetch: document that pruning happens before fetching
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jun 14, 2016, 10:36 UTC
- Message-ID
- <CACsJy8Bbd0=vnbaj4-2m7WKfvWG6PfyXLg1h+970HPsak1hnMQ@mail.gmail.com>
- In-Reply-To
- <20160614102210.GA14357@sigill.intra.peff.net>
On Tue, Jun 14, 2016 at 5:22 PM, Jeff King <peff@peff.net> wrote:
> I think the documentation should be updated either way. This is not > about the ordering in the status table, but rather about the order of > the real operations. The user may care about that ordering if they want > to know what races are possible
Good point.
> or what would happen if the packfile > fetch failed (we'd already have deleted the old refs, but wouldn't fetch > the new ones).
Off topic, but this sounds like a bug to me. We could have kept ref update more consistent (maybe at some point we could even do atomic transaction update for all refs if there's a need for it).
-- Duy