Re: [PATCH] fetch: document that pruning happens before fetching
- From
Jeff King <peff@peff.net>
- Date
- Jun 15, 2016, 03:46 UTC
- Message-ID
- <20160615034629.GB3013@sigill.intra.peff.net>
- In-Reply-To
- <CACsJy8Bbd0=vnbaj4-2m7WKfvWG6PfyXLg1h+970HPsak1hnMQ@mail.gmail.com>
On Tue, Jun 14, 2016 at 05:36:35PM +0700, Duy Nguyen wrote:
Show 7 quoted lines
> > or what would happen if the packfile > > fetch failed (we'd already have deleted the old refs, but wouldn't fetch > > the new ones). > > Off topic, but this sounds like a bug to me. We could have kept ref > update more consistent (maybe at some point we could even do atomic > transaction update for all refs if there's a need for it).
I do think atomic ref transactions are a nice idea, and would probably not be too hard to implement these days (the main thing is just refactoring the deep call stack in git-fetch).
It's possible it could be annoying when you have a single broken ref (and would prefer to just ignore it), but that _should_ be the rare case.
-Peff