git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch: align new ref summary printout in UTF-8 locales

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Sep 4, 2012, 01:31 UTC
Message-ID
<CACsJy8B_aUfg6Cs_23UyjoVwQGrkBtMUoqOBQLTSM2cC=KfR3g@mail.gmail.com>
In-Reply-To
<7vwr0aewlf.fsf@alter.siamese.dyndns.org>
On Tue, Sep 4, 2012 at 2:26 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> fetch does printf("%-*s", width, "foo") where "foo" can be an utf-8
>> string, but width is bytes, not letters. This results in misaligned
>> ref summary table.
>
> "but width is bytes, not letters" is a misleading statement.
>
> Be careful about three different quantities when talking about
> aligning on terminal output with monospaced fonts:
>
>  - How many bytes does the string occupy in memory?
>  - How many unicode codepoints are in the string?
>  - How many display columns does the string occupy on terminal?
>
> Note that some "letters" (e.g. Han) occupy two display columns, and
> you want to measure the "width" and compensate that for "bytes".
> Letter count do not come into the picture for the purpose of aligning
> the terminal output.
Hmm.. I did test with zh_CN.UTF-8 and it seemed to work. I'll check this again.
-- 
Duy
Previous: Junio C HamanoNext: Nguyễn Thái Ngọc Duy
Message 5 of 14 in “fetch: align new ref summary printout in UTF-8 locales”
  1. fetch: align new ref summary printout in UTF-8 localesNguyễn Thái Ngọc Duy, Sep 3, 2012
  2. Junio C HamanoSep 3, 2012
  3. Johannes SixtSep 3, 2012
  4. Junio C HamanoSep 3, 2012
  5. Nguyen Thai Ngoc DuySep 4, 2012
  6. fetch: align new ref summary printout in UTF-8 localesNguyễn Thái Ngọc Duy, Sep 4, 2012
  7. Nguyen Thai Ngoc DuySep 12, 2012
  8. Junio C HamanoSep 12, 2012
  9. Torsten BögershausenSep 12, 2012
  10. Torsten BögershausenSep 5, 2012
  11. Nguyen Thai Ngoc DuySep 6, 2012
  12. Nguyen Thai Ngoc DuySep 6, 2012
  13. Torsten BögershausenSep 6, 2012
  14. Junio C HamanoSep 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.