Re: [PATCH 1/2] sha1_file: replace PATH_MAX buffer wirh strbuf in prepare_packed_git_one()
On Sat, Jun 28, 2014 at 9:47 PM, René Scharfe <l.s.r@web.de> wrote:
Show 12 quoted lines
> - sprintf(path, "%s/pack", objdir);
> - len = strlen(path);
> - dir = opendir(path);
> + strbuf_addstr(&path, objdir);
> + strbuf_addstr(&path, "/pack");
> + dir = opendir(path.buf);
> if (!dir) {
> if (errno != ENOENT)
> error("unable to open object pack directory: %s: %s",
> - path, strerror(errno));
> + path.buf, strerror(errno));
> return;Memory leak. The rest looks good.
--
Duy