Re: [PATCH 1/5] i18n: keep the last \n even when text is poisoned
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Mar 9, 2012, 02:33 UTC
- Message-ID
- <CACsJy8BZi6NG+pixq45dbTMMEXkvy8soma95Zx+UWemxnX2jqw@mail.gmail.com>
- In-Reply-To
- <CACsJy8AcUy9FZiiehGc7mEL4i+XP6u0pmH1rGoR-WZnhYT1UMQ@mail.gmail.com>
On Fri, Mar 9, 2012 at 8:11 AM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
> It's the former for me, but that's probably because I'm also a > translator :) Anyway for tricky cases where msgfmt fails to detect, > there's the role of l10n coordinators, who should review translation > and catch these errors.
On second thought, most of call sites are [fs]printf or strbuf_addf, and we have to update the call sites anyway to mark for translation. If we introduce [fs]printf_ln, changes should be minimum. So now I'm on your side too.
-- Duy