Re: [PATCH] repository.c: fix sparse warning

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 17, 2019, 10:06 UTC
Message-ID: <CACsJy8BWfdCwFwhfKku-AqP5sGpB7CN4O-Qu0b1cm3iTbW8Z_Q@mail.gmail.com>
In-Reply-To: <419519f9-1b48-93bb-eead-eacf6b383f70@ramsayjones.plus.com>

On Thu, Jan 17, 2019 at 8:21 AM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 13 quoted lines

>
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Duy,
>
> If you need to re-roll your 'nd/the-index-final' branch, could you
> please squash this into the relevant patch (commit 4478671442,
> "cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch", 2019-01-12).
>
> [the warning is caused by the lack of the extern declaration of the
> 'the_index' symbol.]

Is it a false alarm? The variable is actually defined in this file now which should also function as a declaration, yes?

Show 20 quoted lines

>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>  repository.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/repository.c b/repository.c
> index 0c6814627e..3ecbb1b6e3 100644
> --- a/repository.c
> +++ b/repository.c
> @@ -1,3 +1,4 @@
> +#define USE_THE_INDEX_COMPATIBILITY_MACROS
>  #include "cache.h"
>  #include "repository.h"
>  #include "object-store.h"
> --
> 2.20.0

-- 
Duy