threads / patch / 50246

patchrepository.c: fix sparse warning

Subject: [PATCH] repository.c: fix sparse warning

## tl;dr

3 messages between Jan 17, 2019 and Jan 17, 2019. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ramsay Jones· Jan 17, 2019, 01:07 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Duy,

If you need to re-roll your 'nd/the-index-final' branch, could you please squash this into the relevant patch (commit 4478671442, "cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch", 2019-01-12).

[the warning is caused by the lack of the extern declaration of the 'the_index' symbol.]

Thanks!

ATB, Ramsay Jones

 repository.c | 1 +
 1 file changed, 1 insertion(+)

Show changes to repository.c +1 −0

diff --git a/repository.c b/repository.c
index 0c6814627e..3ecbb1b6e3 100644
--- a/repository.c
+++ b/repository.c
@@ -1,3 +1,4 @@
+#define USE_THE_INDEX_COMPATIBILITY_MACROS
 #include "cache.h"
 #include "repository.h"
 #include "object-store.h"

-- 
2.20.0

Duy Nguyen· Jan 17, 2019, 10:06 UTC · re: Ramsay Jones · lore

Re: [PATCH] repository.c: fix sparse warning

On Thu, Jan 17, 2019 at 8:21 AM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 13 quoted lines

>
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Duy,
>
> If you need to re-roll your 'nd/the-index-final' branch, could you
> please squash this into the relevant patch (commit 4478671442,
> "cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch", 2019-01-12).
>
> [the warning is caused by the lack of the extern declaration of the
> 'the_index' symbol.]

Is it a false alarm? The variable is actually defined in this file now which should also function as a declaration, yes?

Show 20 quoted lines

>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>  repository.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/repository.c b/repository.c
> index 0c6814627e..3ecbb1b6e3 100644
> --- a/repository.c
> +++ b/repository.c
> @@ -1,3 +1,4 @@
> +#define USE_THE_INDEX_COMPATIBILITY_MACROS
>  #include "cache.h"
>  #include "repository.h"
>  #include "object-store.h"
> --
> 2.20.0

-- 
Duy

Ramsay Jones· Jan 17, 2019, 16:51 UTC · re: Duy Nguyen · lore

Re: [PATCH] repository.c: fix sparse warning

On 17/01/2019 10:06, Duy Nguyen wrote:

Show 18 quoted lines

> On Thu, Jan 17, 2019 at 8:21 AM Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>>
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Duy,
>>
>> If you need to re-roll your 'nd/the-index-final' branch, could you
>> please squash this into the relevant patch (commit 4478671442,
>> "cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch", 2019-01-12).
>>
>> [the warning is caused by the lack of the extern declaration of the
>> 'the_index' symbol.]
> 
> Is it a false alarm? The variable is actually defined in this file now
> which should also function as a declaration, yes?

Ah, no, absolutely not! :( (er, well yes, but no! :-D ).

I hope you agree that _all_ uses of a symbol should be within the scope of the same declaration of that symbol (by #include-ing the same header/interface file). This is _especially_ true of the file which has the definition of that symbol - how else do you expect the compiler to detect a mismatch between the declaration and definition?

ATB, Ramsay Jones