git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix flaky untracked-cache test

From
Duy Nguyen <pclouds@gmail.com>
Date
Oct 21, 2015, 20:25 UTC
Message-ID
<CACsJy8BRFvD=kVH6-W1j+PgHdNYCmuwrKXTADmHG=AQPv9GUUA@mail.gmail.com>
In-Reply-To
<1445284095-6602-1-git-send-email-dturner@twopensource.com>
On Mon, Oct 19, 2015 at 9:48 PM, David Turner <dturner@twopensource.com> wrote:
Show 9 quoted lines
> Dirty the test worktree's root directory, as the test expects.
>
> When testing the untracked-cache, we previously assumed that checking
> out master would be sufficient to mark the mtime of the worktree's
> root directory as racily-dirty.  But sometimes, the checkout would
> happen at 12345.999 seconds and the status at 12346.001 seconds,
> meaning that the worktree's root directory would not be racily-dirty.
> And since it was not truly dirty, occasionally the test would fail.
> By making the root truly dirty, the test will always succeed.

I'm sorry for my deadly silence lately. I hope it will end in a few weeks. From a quick glance, the description and the change look ok (but don't weigh too much on my opinion).

Back to my silence..
-- 
Duy
Previous: David TurnerNext: Lars Schneider
Message 4 of 5 in “fix flaky untracked-cache test”
  1. fix flaky untracked-cache testDavid Turner, Oct 19, 2015
  2. Torsten BögershausenOct 21, 2015
  3. David TurnerOct 21, 2015
  4. Duy NguyenOct 21, 2015
  5. Lars SchneiderOct 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.