From: Duy Nguyen <pclouds@gmail.com>
Date: Wed, 21 Oct 2015 20:25:39 GMT
Subject: Re: [PATCH] fix flaky untracked-cache test
Message-ID: <CACsJy8BRFvD=kVH6-W1j+PgHdNYCmuwrKXTADmHG=AQPv9GUUA@mail.gmail.com>
In-Reply-To: <1445284095-6602-1-git-send-email-dturner@twopensource.com>

On Mon, Oct 19, 2015 at 9:48 PM, David Turner <dturner@twopensource.com> wrote:
> Dirty the test worktree's root directory, as the test expects.
>
> When testing the untracked-cache, we previously assumed that checking
> out master would be sufficient to mark the mtime of the worktree's
> root directory as racily-dirty.  But sometimes, the checkout would
> happen at 12345.999 seconds and the status at 12346.001 seconds,
> meaning that the worktree's root directory would not be racily-dirty.
> And since it was not truly dirty, occasionally the test would fail.
> By making the root truly dirty, the test will always succeed.

I'm sorry for my deadly silence lately. I hope it will end in a few
weeks. From a quick glance, the description and the change look ok
(but don't weigh too much on my opinion).

Back to my silence..
-- 
Duy