Re: [PATCH/WIP v2 08/14] read-cache: add GIT_TEST_FORCE_WATCHER for testing

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 20, 2014, 01:32 UTC
Message-ID: <CACsJy8BQ-Z5NtmxDhLw98q_rianK7Ny_pJLubQ8=KtmTA9g8kg@mail.gmail.com>
In-Reply-To: <87lhybewcs.fsf@thomasrast.ch>

On Mon, Jan 20, 2014 at 12:04 AM, Thomas Rast <tr@thomasrast.ch> wrote:

Show 12 quoted lines

> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> This can be used to force watcher on when running the test
>> suite.
>>
>> git-file-watcher processes are not automatically cleaned up after each
>> test. So after running the test suite you'll be left with plenty
>> git-file-watcher processes that should all end after about a minute.
>
> Probably not a very good idea, especially in noninteractive use?  E.g.,
> a bisection through the test suite or parallel test runs on different
> commits may exhaust the available processes and/or memory.

I think we run out of inotify resources before hitting process/memory limits. At least that's the case when running tests in parallel.

> Each test should make an effort to clean up all watchers before
> terminating.

For now it's hard to do this correctly. Maybe once we get the multi-repo file watcher, we could launch one watcher per trash directory and cleaning up would be easier.

-- 
Duy