Re: [PATCH/WIP v2 08/14] read-cache: add GIT_TEST_FORCE_WATCHER for testing

From: Thomas Rast <tr@thomasrast.ch>
Date: Jan 19, 2014, 17:04 UTC
Message-ID: <87lhybewcs.fsf@thomasrast.ch>
In-Reply-To: <1389952060-12297-9-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

Show 6 quoted lines

> This can be used to force watcher on when running the test
> suite.
>
> git-file-watcher processes are not automatically cleaned up after each
> test. So after running the test suite you'll be left with plenty
> git-file-watcher processes that should all end after about a minute.

Probably not a very good idea, especially in noninteractive use? E.g., a bisection through the test suite or parallel test runs on different commits may exhaust the available processes and/or memory.

Each test should make an effort to clean up all watchers before terminating.

Show 23 quoted lines

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  read-cache.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/read-cache.c b/read-cache.c
> index 5dae9eb..a1245d4 100644
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -1544,7 +1544,12 @@ static void validate_watcher(struct index_state *istate, const char *path)
>  	}
>  
>  	if (autorun_watcher == -1) {
> -		git_config(watcher_config, NULL);
> +		if (getenv("GIT_TEST_FORCE_WATCHER")) {
> +			watch_lowerlimit = 0;
> +			recent_limit = 0;
> +			autorun_watcher = 1;
> +		} else
> +			git_config(watcher_config, NULL);
>  		if (autorun_watcher == -1)
>  			autorun_watcher = 0;
>  	}

-- 
Thomas Rast
tr@thomasrast.ch