Re: [PATCH 2/2] dir: remove PATH_MAX limitation
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jul 12, 2014, 02:56 UTC
- Message-ID
- <CACsJy8BOdQwht_b2D48cZP-NFosT2FxGg+hkEthsGBvW7EE=FQ@mail.gmail.com>
- In-Reply-To
- <53C076B8.9030209@gmail.com>
On Sat, Jul 12, 2014 at 6:43 AM, Karsten Blees <karsten.blees@gmail.com> wrote:
Show 26 quoted lines
> Am 12.07.2014 00:29, schrieb Junio C Hamano: >> Karsten Blees <karsten.blees@gmail.com> writes: >> >>> Anyways, I'd like to kindly withdraw this patch in favor of Duy's version. >>> >>> http://article.gmane.org/gmane.comp.version-control.git/248310 >> >> Thanks; I've already reverted it from 'next'. >> >> Is Duy's patch still viable? >> > > I think so. It fixes the segfault with long paths on Windows as well > (Tested-by: <me>), uses strbuf APIs as Peff suggested, and initializes the > strbuf with PATH_MAX (i.e. no reallocs in the common case either ;-) ). > > AFAICT the first two patches of that series are also completely unrelated > to the untracked-cache, so we may want to fast-track these? > > [01/20] dir.c: coding style fix > [02/20] dir.h: move struct exclude declaration to top level > [03/20] prep_exclude: remove the artificial PATH_MAX limit > > ...perhaps with s/if (!dir->basebuf.alloc)/if (!dir->basebuf.buf)/ > > @Duy any reason for not signing off that series?
That series still need a lot more work, but for those first three, if you want to fast track, you have my sign-offs.
-- Duy -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.