git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

From
Karsten Blees <karsten.blees@gmail.com>
Date
Jul 11, 2014, 23:43 UTC
Message-ID
<53C076B8.9030209@gmail.com>
In-Reply-To
<xmqq4myn34xo.fsf@gitster.dls.corp.google.com>
Am 12.07.2014 00:29, schrieb Junio C Hamano:
Show 10 quoted lines
> Karsten Blees <karsten.blees@gmail.com> writes:
> 
>> Anyways, I'd like to kindly withdraw this patch in favor of Duy's version.
>>
>> http://article.gmane.org/gmane.comp.version-control.git/248310
> 
> Thanks; I've already reverted it from 'next'.
> 
> Is Duy's patch still viable?
>

I think so. It fixes the segfault with long paths on Windows as well (Tested-by: <me>), uses strbuf APIs as Peff suggested, and initializes the strbuf with PATH_MAX (i.e. no reallocs in the common case either ;-) ).

AFAICT the first two patches of that series are also completely unrelated to the untracked-cache, so we may want to fast-track these?

[01/20] dir.c: coding style fix [02/20] dir.h: move struct exclude declaration to top level [03/20] prep_exclude: remove the artificial PATH_MAX limit

...perhaps with s/if (!dir->basebuf.alloc)/if (!dir->basebuf.buf)/
@Duy any reason for not signing off that series?
-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Junio C HamanoNext: Duy Nguyen
Message 9 of 16 in “symlinks: remove PATH_MAX limitation”
  1. 1/2 symlinks: remove PATH_MAX limitationKarsten Blees, Jul 4, 2014
  2. 2/2 dir: remove PATH_MAX limitationKarsten Blees, Jul 4, 2014
  3. Duy NguyenJul 5, 2014
  4. Karsten BleesJul 11, 2014
  5. Jeff KingJul 9, 2014
  6. Junio C HamanoJul 9, 2014
  7. Karsten BleesJul 11, 2014
  8. Junio C HamanoJul 11, 2014
  9. Karsten BleesJul 11, 2014
  10. Duy NguyenJul 12, 2014
  11. Junio C HamanoJul 14, 2014
  12. Johannes SchindelinJul 5, 2014
  13. Junio C HamanoJul 7, 2014
  14. Karsten BleesJul 11, 2014
  15. Junio C HamanoJul 11, 2014
  16. fixup! symlinks: remove PATH_MAX limitationKarsten Blees, Jul 11, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.