git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bisect.c: make show_list() build again

From
Duy Nguyen <pclouds@gmail.com>
Date
Sep 3, 2018, 17:31 UTC
Message-ID
<CACsJy8BOZy5MBsSwvHNsWeAf4tqtRJc0SJuBtfwM9wR8Yn_xfw@mail.gmail.com>
In-Reply-To
<CAP8UFD0MHUN=auZW9Zu+hnx6oAxjNsZUfQGeJ0HfBCh5RPv6jg@mail.gmail.com>

On Sun, Sep 2, 2018 at 9:57 AM Christian Couder <christian.couder@gmail.com> wrote:

Show 12 quoted lines
>
> On Sun, Sep 2, 2018 at 9:42 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>
> > In order to stop this from happening again, the function is now
> > compiled unconditionally but exits early unless DEBUG_BISECT is
> > non-zero.
>
> Thanks for going the extra mile and doing this!
>
> I wonder if we should also try to make the show_list() function part
> of the trace_*() functions to make it even more regular. This can be a
> separate patch or topic though.

Yeah that's probably a good idea (though I'm not familiar with bisect.c enough to take that step).

-- 
Duy
Previous: Christian CouderNext: Christian Couder
Message 10 of 12 in “Implement --first-parent for git rev-list --bisect”
  1. Implement --first-parent for git rev-list --bisectTiago Botelho, Aug 28, 2018
  2. Johannes SchindelinAug 28, 2018
  3. Junio C HamanoAug 28, 2018
  4. Junio C HamanoAug 28, 2018
  5. Junio C HamanoAug 28, 2018
  6. Junio C HamanoAug 28, 2018
  7. Duy NguyenSep 2, 2018
  8. bisect.c: make show_list() build againNguyễn Thái Ngọc Duy, Sep 2, 2018
  9. Christian CouderSep 2, 2018
  10. Duy NguyenSep 3, 2018
  11. Christian CouderSep 4, 2018
  12. Junio C HamanoSep 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.