From: Duy Nguyen <pclouds@gmail.com>
Date: Mon, 03 Sep 2018 17:31:54 GMT
Subject: Re: [PATCH] bisect.c: make show_list() build again
Message-ID: <CACsJy8BOZy5MBsSwvHNsWeAf4tqtRJc0SJuBtfwM9wR8Yn_xfw@mail.gmail.com>
In-Reply-To: <CAP8UFD0MHUN=auZW9Zu+hnx6oAxjNsZUfQGeJ0HfBCh5RPv6jg@mail.gmail.com>

On Sun, Sep 2, 2018 at 9:57 AM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Sun, Sep 2, 2018 at 9:42 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>
> > In order to stop this from happening again, the function is now
> > compiled unconditionally but exits early unless DEBUG_BISECT is
> > non-zero.
>
> Thanks for going the extra mile and doing this!
>
> I wonder if we should also try to make the show_list() function part
> of the trace_*() functions to make it even more regular. This can be a
> separate patch or topic though.

Yeah that's probably a good idea (though I'm not familiar with
bisect.c enough to take that step).
-- 
Duy