Re: [PATCH 3/3] execv_dashed_external: wait for child on signal death

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 7, 2017, 09:07 UTC
Message-ID: <CACsJy8BL+THd62J9e4QxuJ7HozUDe05959mTXBMK6E5i6a7WRQ@mail.gmail.com>
In-Reply-To: <20170107012223.c27toqr6ck44kfpj@sigill.intra.peff.net>

On Sat, Jan 7, 2017 at 8:22 AM, Jeff King <peff@peff.net> wrote:

Show 9 quoted lines

> When you hit ^C to interrupt a git command going to a pager,
> this usually leaves the pager running. But when a dashed
> external is in use, the pager ends up in a funny state and
> quits (but only after eating one more character from the
> terminal!). This fixes it.
>
> Explaining the reason will require a little background.
>
> ...

I see I have exposed a bug and I'm glad you are around to fix it. Even reading your explanation is scary enough, let alone finding it. Thanks!

-- 
Duy