Re: Regression: Ctrl-c from the pager in an alias exits it

From: Jeff King <peff@peff.net>
Date: Jan 6, 2017, 06:47 UTC
Message-ID: <20170106064752.iccrk656c6k2wrfy@sigill.intra.peff.net>
In-Reply-To: <20170106064032.eqxxer5mx5hsh2md@sigill.intra.peff.net>

On Fri, Jan 06, 2017 at 01:40:32AM -0500, Jeff King wrote:

Show 14 quoted lines

> On Thu, Jan 05, 2017 at 03:25:29PM +0100, Trygve Aaberge wrote:
> 
> > I'm experiencing an issue when using aliases for commands that open the pager.
> > When I press Ctrl-c from the pager, it exits. This does not happen when I
> > don't use an alias and did not happen before. It causes problems because
> > Ctrl-c is also used for other things, such as canceling a search that hasn't
> > completed.
> > 
> > To reproduce, create e.g. the alias `l = log` and run `git l`. Then press
> > Ctrl-c. The expected behavior is that nothing happens. The actual behavior is
> > that the pager exits.
> 
> That's weird. I can't reproduce at all here. But I also can't think of a
> thing that Git could do that would impact the behavior. For example:

I take it back. I could not reproduce under my normal config, which sets the pager to "diff-highlight | less". But if I drop that config, I can reproduce easily. And bisect it to that same commit, 86d26f240f (setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when .., 2015-12-20).

-Peff