Re: [PATCH v3 2/4] refs: introduce get_worktree_ref_store()
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Mar 20, 2017, 12:01 UTC
- Message-ID
- <CACsJy8B85TH0DOViEmfh8mOz_u7rVotKJa-HYk6TJ81kvV4xPg@mail.gmail.com>
- In-Reply-To
- <b841a674-7b2b-420d-7faa-e5b836fb534e@alum.mit.edu>
On Mon, Mar 20, 2017 at 1:59 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> I guess I can hold my nose and accept storing worktree and submodule > `ref_store`s together in a single hashmap
Release your nose, I'll add a new hashmap :) But while we're here, what are your thoughts about moving submodule-specific to submodule.c? That includes the hashmap, get_submodule_ref_store() and all other submodule stuff, to submodule.c where submodule-specific stuff stays. The same for worktree stuff, to worktree.c. That keeps refs.c to core refs business. And the hashmap can be used for more than just refs. For example, submodule has configs, and worktree also has bunch of other stuff that I would like to just cache and not readdir() and parse every time.
-- Duy