Re: [PATCH v4 0/5] Kill manual ref parsing code in worktree.c

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Apr 22, 2017, 05:06 UTC
Message-ID: <93a5e70b-9c37-6c77-7c42-be253d27f277@alum.mit.edu>
In-Reply-To: <xmqqk26nojfm.fsf@gitster.mtv.corp.google.com>

On 04/14/2017 03:40 AM, Junio C Hamano wrote:

Show 14 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
> 
>> v4 adds a new patch, 2/5, which makes the hashmap related functions in
>> refs.c generic, so I could add a new map for worktree ref stores and
>> not abuse submodule hashmap.
>>
>> I mentioned about moving these hashmap back to submodule.c and
>> worktree.c where it can map more than just ref stores (in worktree
>> case, we can cache 'struct worktree', for example). But I'm not doing
>> it now to keep things small.
>>
>> The commit message in 1/5 is rephrased a bit, hopefully clearer.
> 
> Michael, does this look good to replace what has been queued?

I finally reviewed this patch series. The refs-related changes look fine, and the submodule-related changes (which I'm not so familiar with) looks plausible.

It's a nice cleanup :-)

Michael