git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] upload-pack: ignore 'shallow' lines with unknown obj-ids

From
Duy Nguyen <pclouds@gmail.com>
Date
Apr 20, 2013, 10:34 UTC
Message-ID
<CACsJy8B6OYC-Qcwc53BsVtUSHw1ag6LWF2rBSP6agO6yTXQo+g@mail.gmail.com>
In-Reply-To
<CAJDSCnN6Ekp3wF9hX9Dbt3+CLNg1_aBz8nPGUuCu0WS9MF8aXA@mail.gmail.com>

On Sat, Apr 20, 2013 at 8:05 PM, Michael Heemskerk <mheemskerk@atlassian.com> wrote:

Show 14 quoted lines
> When the client sends a 'shallow' line for an object that the server does
> not have, the server currently dies with the error: "did not find object
> for shallow <obj-id>". The client may have received the object from a
> different server, or the object may have been garbage collected by the
> server. In either case, the object is not relevant for calculating the pack
> that is to be sent and can be safely ignored.
>
> The documentation in technical/pack-protocol.txt has been updated to
> remove the restriction that "Clients MUST NOT mention an obj-id which it
> does not know exists on the server". This requirement is not realistic
> because clients cannot know whether an object has been garbage collected
> by the server.
>
> Signed-off-by: Michael Heemskerk <mheemskerk@atlassian.com>

I'm not an expert in git protocol (or shallow extension in particular) but the reasoning sounds right and the implemention looks correct.

Acked-by: Duy Nguyen <pclouds@gmail.com>
--
Duy
Next: Junio C Hamano
Message 1 of 7 in “Re: [PATCH/RFC] upload-pack: ignore 'shallow' lines with unknown obj-ids”
  1. Duy NguyenApr 20, 2013
  2. Junio C HamanoApr 20, 2013
  3. Duy NguyenApr 20, 2013
  4. Fwd: [PATCH/RFC] upload-pack: ignore 'shallow' lines with unknown obj-idsMichael Heemskerk, Apr 21, 2013
  5. Junio C HamanoApr 29, 2013
  6. Junio C HamanoApr 29, 2013
  7. Michael HeemskerkApr 29, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.