From: Duy Nguyen <pclouds@gmail.com>
Date: Sat, 20 Apr 2013 10:34:41 GMT
Subject: Re: [PATCH/RFC] upload-pack: ignore 'shallow' lines with unknown obj-ids
Message-ID: <CACsJy8B6OYC-Qcwc53BsVtUSHw1ag6LWF2rBSP6agO6yTXQo+g@mail.gmail.com>
In-Reply-To: <CAJDSCnN6Ekp3wF9hX9Dbt3+CLNg1_aBz8nPGUuCu0WS9MF8aXA@mail.gmail.com>

On Sat, Apr 20, 2013 at 8:05 PM, Michael Heemskerk
<mheemskerk@atlassian.com> wrote:
> When the client sends a 'shallow' line for an object that the server does
> not have, the server currently dies with the error: "did not find object
> for shallow <obj-id>". The client may have received the object from a
> different server, or the object may have been garbage collected by the
> server. In either case, the object is not relevant for calculating the pack
> that is to be sent and can be safely ignored.
>
> The documentation in technical/pack-protocol.txt has been updated to
> remove the restriction that "Clients MUST NOT mention an obj-id which it
> does not know exists on the server". This requirement is not realistic
> because clients cannot know whether an object has been garbage collected
> by the server.
>
> Signed-off-by: Michael Heemskerk <mheemskerk@atlassian.com>

I'm not an expert in git protocol (or shallow extension in particular)
but the reasoning sounds right and the implemention looks correct.

Acked-by: Duy Nguyen <pclouds@gmail.com>
--
Duy