Re: [PATCH] protocol upload-pack-v2

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 7, 2015, 00:00 UTC
Message-ID: <CACsJy8B5jdKt0h8pTn8hVrbEw3o-gRLmoP+MBMMpm-reKtBOvQ@mail.gmail.com>
In-Reply-To: <1425685087-21633-1-git-send-email-sbeller@google.com>

On Sat, Mar 7, 2015 at 6:38 AM, Stefan Beller <sbeller@google.com> wrote:

Show 14 quoted lines

> +Reference Discovery (v2)
> +------------------------
> +
> +In version 2, reference discovery is initiated by the client with
> +"want-refs" line. The client may skip reference discovery phase
> +entirely by not sending "want-refs" (e.g. the client has another way
> +to retrieve ref list).
> +
> +----
> +  want-refs  =  PKT-LINE("want-refs" SP mode *argument)
> +  mode       =  "all"
> +  argument   =  SP arg
> +  arg        =  1*(LC_ALPHA / DIGIT / "-" / "_" / "=")
> +----

On the same line with capabilities, we would not want to run into a situation where we have too many arguments to send and exceed pkt-line limit. So perhaps do one argument per pkt-line too, ending with a pkt-flush.

-- 
Duy