Re: [PATCH] pathspec: adjust prefixlen after striping trailing slash

From: Duy Nguyen <pclouds@gmail.com>
Date: Apr 20, 2015, 05:52 UTC
Message-ID: <CACsJy8B1QWzehAEtjnQeRJ8uehcFFDbdHSViwk_JtrtYehV8ZQ@mail.gmail.com>
In-Reply-To: <xmqqy4lnmkbv.fsf@gitster.dls.corp.google.com>

On Mon, Apr 20, 2015 at 12:37 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Duy Nguyen <pclouds@gmail.com> writes:
>
>> But if you look at it another way, "cd subrepo; git add ." should be
>> the same as "git add subrepo" ...
>
> Once you cd into "subrepo", you are in a different world, a world
> different from the toplevel project.  "git add ." over there should
> mean "add everything in subproject's working tree to subproject's
> index", shouldn't it?  On the other hand, "git add subrepo" without
> leavingin the working tree of the superproject is about binding the
> submodule to the superproject's index.
>
> I do not think these two should be the same.  Where am I mistaken?

I think I wrote this sentence and deleted it: I didn't say which way was right. I simply looked at this from the implementation perspective and it looked the same, at least with current impl. But we can differentiate them if we want (prefixlen is the key). A corner case if we go with erroring out in "cd subrepo; git add ." case, do we error out with "cd subrepo; git add ../subrepo"? If we want this case to error out too, I don't think I can use prefixlen to set it apart from "git add subrepo" any more..

-- 
Duy