Re: [PATCH] clone: local URLs are not for ssh

From: Duy Nguyen <pclouds@gmail.com>
Date: Sep 29, 2013, 00:33 UTC
Message-ID: <CACsJy8B-wA=bX6+E6O6UvX2vEtOwnR1PCMZNoi-q0x_jacB89Q@mail.gmail.com>
In-Reply-To: <201309282137.21802.tboegi@web.de>

On Sun, Sep 29, 2013 at 2:37 AM, Torsten Bögershausen <tboegi@web.de> wrote:

> "git clone /foo/bar:baz" or "git clone ../foo/bar:baz"
> are meant to clone from the local file system, and not to clone
> from a remote server over git-over-ssh.

I don't think this is necessary. Commit 6000334 should detect both cases fine because both have a slash before the first colon.

Show 23 quoted lines

>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
>  connect.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/connect.c b/connect.c
> index a80ebd3..b382032 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -550,7 +550,8 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
>                 end = host;
>
>         path = strchr(end, c);
> -       if (path && !has_dos_drive_prefix(end)) {
> +       if (path && !has_dos_drive_prefix(end) &&
> +           url[0] != '/' && url[0] != '.' ) {
>                 if (c == ':') {
>                         if (path < strchrnul(host, '/')) {
>                                 protocol = PROTO_SSH;
> --
> 1.8.4.457.g424cb08
>

-- 
Duy