Re: [PATCH] clone: local URLs are not for ssh

From: Torsten Bögershausen <tboegi@web.de>
Date: Oct 2, 2013, 18:40 UTC
Message-ID: <524C6885.8020602@web.de>
In-Reply-To: <CACsJy8B-wA=bX6+E6O6UvX2vEtOwnR1PCMZNoi-q0x_jacB89Q@mail.gmail.com>

On 2013-09-29 02.33, Duy Nguyen wrote:

Show 7 quoted lines

> On Sun, Sep 29, 2013 at 2:37 AM, Torsten Bögershausen <tboegi@web.de> wrote:
>> "git clone /foo/bar:baz" or "git clone ../foo/bar:baz"
>> are meant to clone from the local file system, and not to clone
>> from a remote server over git-over-ssh.
> 
> I don't think this is necessary. Commit 6000334 should detect both
> cases fine because both have a slash before the first colon.

Sorry for the noise, I noticed it when I was trying to construct test cases.

What do we think about adding this at the end of t5505:

test_expect_success 'fetch fail [noexistinghost0:2223]:blink.git' '
	(
		! git fetch [noexistinghost0:2223]:blink.git 2>err &&
		grep ssh err &&
		rm err
	)
'

test_expect_success 'fetch fail noexistinghost1:2223:blink.git' '
	(
		! git fetch "noexistinghost1:2223:blink.git" 2>err &&
		grep ssh err &&
		rm err
	)
'

test_expect_success 'fetch fail noexistinghost2:2223' '
	(
		! git fetch "noexistinghost2:2223" 2>err &&
		grep ssh err &&
		rm err
	)
'
test_expect_success 'fetch fail ./noexistinghost4:2223"' '
	(
		! git fetch "./noexistinghost4:2223" 2>err &&
		grep "does not appear to be a git repository" err &&
		rm err
	)
'