git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] dir.c: make last_exclude_matching_from_list() run til the end

From
Duy Nguyen <pclouds@gmail.com>
Date
Aug 31, 2015, 10:13 UTC
Message-ID
<CACsJy8AwV9J9hs4uyZ0eCy0vFMat4dYaQy+6mVkcK7KvRw2bgg@mail.gmail.com>
In-Reply-To
<xmqqmvxfxgdj.fsf@gitster.dls.corp.google.com>
On Wed, Aug 26, 2015 at 3:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>
> Because?  Title just tells what the patch meant to do (i.e. instead
> of returning it keeps looping), but does not say why it is a good
> idea.  Besides, this a no-op patch and does not make it keep looping.

Because the next patch adds some post processing before returning the value. Having all the paths come to the same point would simplify the code. Will update the commit message.

-- 
Duy
Previous: Junio C HamanoNext: Nguyễn Thái Ngọc Duy
Message 4 of 10 in “gitignore, re-inclusion fix”
  1. 0/2 gitignore, re-inclusion fixNguyễn Thái Ngọc Duy, Aug 23, 2015
  2. 1/2 dir.c: make last_exclude_matching_from_list() run til the endNguyễn Thái Ngọc Duy, Aug 23, 2015
  3. Junio C HamanoAug 25, 2015
  4. Duy NguyenAug 31, 2015
  5. 2/2 dir.c: don't exclude whole dir prematurely if neg pattern may matchNguyễn Thái Ngọc Duy, Aug 23, 2015
  6. 0/2 gitignore, re-inclusion fixNguyễn Thái Ngọc Duy, Sep 13, 2015
  7. 1/2 dir.c: make last_exclude_matching_from_list() run til the endNguyễn Thái Ngọc Duy, Sep 13, 2015
  8. 2/2 dir.c: don't exclude whole dir prematurely if neg pattern may matchNguyễn Thái Ngọc Duy, Sep 13, 2015
  9. Junio C HamanoSep 14, 2015
  10. Duy NguyenSep 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.