From: Duy Nguyen <pclouds@gmail.com>
Date: Mon, 31 Aug 2015 10:13:26 GMT
Subject: Re: [PATCH 1/2] dir.c: make last_exclude_matching_from_list() run til the end
Message-ID: <CACsJy8AwV9J9hs4uyZ0eCy0vFMat4dYaQy+6mVkcK7KvRw2bgg@mail.gmail.com>
In-Reply-To: <xmqqmvxfxgdj.fsf@gitster.dls.corp.google.com>

On Wed, Aug 26, 2015 at 3:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>
> Because?  Title just tells what the patch meant to do (i.e. instead
> of returning it keeps looping), but does not say why it is a good
> idea.  Besides, this a no-op patch and does not make it keep looping.

Because the next patch adds some post processing before returning the
value. Having all the paths come to the same point would simplify the
code. Will update the commit message.
-- 
Duy